🌱 refactor tags package to support other services #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing tags package applies tags to EC2 only. This is a small refactor to allow a 'apply' function to be passed in and this function contains resource/service specific functionality to apply the tags. The tags package still keeps the diff functionality and this can be used by new services such as EKS.
k8s-ci-robot
added
cncf-cla: yes
vincepri
reviewed
Jul 30, 2020
richardcase
changed the title
Changed the tags package to use a builder struct thats created with opts. Moved the EC2 tag setting back into the package.
richardcase
changed the title
|
/lgtm i'll leave final approve up to @vincepri? :D |
k8s-ci-robot
added
the
lgtm
|
@vincepri is off this week, I'll take a look. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
randomvariable
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The existing tags package applies tags to EC2 only. This is a small refactor to allow a 'apply' function to be passed in and this function contains resource/service specific functionality to applythe tags. The tags package still keeps the diff functionality. This will help with apply tags in the EKS control plane reconciler ( #1787 ).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1843